Hi @Pross, good question.
For now, I’d be happy to get these specific changes for PHP 7.3+ compatibility ported over to ClassicPress, so please do submit a PR. It may be a little while until we merge it, though, since we’re currently busy preparing for the first beta release.
Longer-term, I’ve started planning for a general effort to port relevant WP 5 (and 4.9.x) changes back over to ClassicPress on an ongoing basis. We have a web app that can help with this:
It’s not finished, right now it just shows a list of commits and not much else. The goals for this app are the following:
- Allow viewing each change and showing a diff, as well as a diff against the ClassicPress source tree that includes information about any conflicts
- Allow discussing each change
- Allow marking a change as “not wanted” or submitting a PR
And then a couple more things that would be nice:
- In the commit messages as shown in the app and as submitted in a PR, turn
#ticket references into fully-qualified links
- Decipher and link together “backport” commits from different WP branches
As you can see, there are a lot of commits to sort through, so we will probably also want to split the commits by pages and add a filter for commits we haven’t decided what to do with yet.
The code for this app is at https://github.com/ClassicPress/ClassicPress-Bots - pull requests welcome there too.
I haven’t documented how to develop against this app locally yet, so I’ll write some basics here.
Basically you need to be running at least PHP 7.1 (you can use
phpbrew for this if you don’t have it installed locally).
Then you can set up your
.env file with a MySQL database and run the following:
php artisan migrate
php artisan serve --host=bots.classicpress.local --port=8000
Some more information about how the app uses
git repos to do its work, and the setup needed to make that part work, is here: https://github.com/ClassicPress/ClassicPress-Bots/wiki
To test the app features related to logging in, you’ll need to set up a GitHub OAuth app at https://github.com/settings/developers and fill in the relevant details in