Yes, I think I have it all worked out now. Great work!
Any reason you decided to put the link at the very top of admin menu?
Thanks! When working on a plugin, I often force its entry to the top for ease of access. In this case, since plugins are my main thing, it made sense to keep it up top. I considered moving it down…but, to where… I get that some people aren’t going to want this, though, so, I added a filter that allows you to place it where you prefer. I will probably reverse this behavior… allowing the item to fall in naturally and leaving the filter in place for those (like me) who want it in a different location.
This was well worth the wait, thank you for putting out
Just took it for a test drive and although it took a little bit of a head scratch I got it to do exactly what it says on the tin.
Not sure if this is a conflict or just the way updates work but initially I wasn’t getting the update to show up then I remembered I had previously been using the GitHub updater so reactivated that, cleared cache and deactivated it again and just like that, the available update appeared.
P.S. Couldn’t find where to put my 5stars so left the only available 1 on GitHub - I guess it can be considered a 1+++++ rating
Thanks for the kind works – and starring the repo! I’ll add your comments to the “opinions” section on my site (if you don’t mind)… It’s really good to hear that you did a bit of head-scratch to start, but, ultimately worked it out. This tells me it’s figure-out-able, which is always a good thing.
In terms of how ClassicPress updates work, the system is designed to check for updates only every 12 hours, simply for performance reasons. I found that clicking the
Check Again button on the updates page didn’t always do the trick, however, a hard refresh in the address bar usually pulled up the update. In a few cases, it seemed to take forever. I eventually started deleting the transient directly during development to ensure the check was performed. In terms of waiting around for transients to expire, “aint nobody got time for that.”
No, wouldn’t mind if you did
Wow, works great!
Only thing I can notice is that “view details” in plugin page is visible only when an update is available.
Tell me if I’m wrong - the class must stay in a subfolder?
Glad to hear!
That’s a good point about the “view details” link.
UpdateClient.class.php file: you can place it anywhere in your remotely-updatable plugins; as long as you include or require it (once) somewhere in your plugin’s code. On that note, you can also name the file whatever you like. So, just to clarify that, you can place/name this file however you like in a remotely-updatable plugin, however, it should remain intact in the Update Manager plugin to ensure that the Update Manager can still receive updates for itself.
As a hint, when GitHub updater plugin is active, the link is shown.
Did just a quick test, it is not working if placed in the root folder of the plugin. It works if placed on a subfolder (with whatever name you want).
I just did a quick test with the class in the root the requiring it without a path.
… it picked up the update. I’m wondering if maybe you are using an incorrect path variable in your include… or if you’re using a URL instead of a path to include the file. Your error logs should point out anything out of the ordinary. If you continue to experience this, please open an issue.
I’m asking here as it may be useful for others. Can you give a pointer as to how I get our logo showing up here:
Just add a file called “icon.xxx” in the “images” folder in the root of your plugin. You can use svg, jpg or png.
The image is square.
Same for the banner that is displaied when you click “view details” when a new version is ready. 772x250 is the right size for this.
Thanks Simone. Actually it needs to be icon.xxx (and banner.xxx) but I got it working now.
Sorry… sunday raining morning ! I’ve corrected my post.
Thanks @Simone, that should only work for svg images. The supported images/types/filenames are:
screenshot-2..png , …
screenshot-2.jpg , …
You should be able to use any combination of the above. For example, if you only had an svg icon, a png header, and jpg screenshots… it should just work if you name the files according to the above.
11 posts were split to a new topic: Brut Force Login Protection + Update Manager