Login username. Modifiability and security

[iljester]

@Simone

I haven’t looked deeply at the code, but I think it’s not a core problem to make the username editable.
But it’s a breaking change because plugins can rely on username instead of ID, so it’s something not actionable until version 3 of classicPress.

About leaking of informations, the username is not considered as something that must be secured. Security is achieved through passwords (and as I do on some of my sites 2FA).

1. In reality, relying on the username is not a good way to design, precisely because it can be changed. The ID is the only data you should rely on when writing a plugin.

2. The fact that the username is not “sensitive” data for security purposes may be true up to a certain point. Not everyone adopts the 2FA approach, and brute force attacks on sites without adequate protection (absence of a limit on incorrect logins, xmlrpc active) and with part of the login known, can easily overcome the bland defense of a password.
   My philosophical approach is that CP should do everything to protect the user’s account, eliminating any even minimal and remote security problems.
   Then, of course, if one intends to create an impassable wall, he equips himself with a robust plugin that does that protection job.