james
August 29, 2021, 6:51pm
41
This looks like a good start
Does wpautop still work (insofar as such a thing can be said to “work” anyway)? Inserting/manipulating media files? Links? What about the other TinyMCE plugins loaded from ClassicPress/src/wp-includes/js/tinymce/plugins at develop · ClassicPress/ClassicPress · GitHub ?
3 Likes
I’m doing a bit of cleanup and renaming it to “ClassicPress Editor” before publishing. After I grab a bite, I’ll run through the various features and see what works and doesn’t. Then, when I publish it to the research repo, I’ll provide notes to ensure everyone’s on the same page to start.
6 Likes
james
August 29, 2021, 8:01pm
43
No need to test all of those yourself either, but at least leaving the testing of all TinyMCE plugins as an action item would be good.
1 Like
james
August 29, 2021, 9:28pm
45
I’ve created an issue / task list for what is probably most of the remaining work here:
opened 09:27PM - 29 Aug 21 UTC
task-list
Completing this task will ensure that all CP-centric features (inserting and man… aging media with the CP media library, inserting and managing links with knowledge of the site's posts/pages, embedding videos, etc) continue to work correctly.
Warning, this is likely to be a lot of work. Testing and fixes could be completed after an initial release of the plugin to make it easier to get people to help test, but the plugin should stay in **beta** status until this is completed.
List of current TinyMCE plugins, taken from [the core code](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins):
- [x] TinyMCE plugin: [charmap](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/charmap)
- [x] TinyMCE plugin: [colorpicker](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/colorpicker)
- [ ] TinyMCE plugin: [compat3x](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/compat3x)
- [x] TinyMCE plugin: [directionality](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/directionality)
- [x] TinyMCE plugin: [fullscreen](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/fullscreen)
- [x] TinyMCE plugin: [hr](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/hr)
- [x] TinyMCE plugin: [image](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/image)
- [x] TinyMCE plugin: [link](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/link)
- [x] TinyMCE plugin: [lists](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/lists)
- [x] TinyMCE plugin: [media](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/media)
- [x] TinyMCE plugin: [paste](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/paste)
- [x] TinyMCE plugin: [tabfocus](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/tabfocus)
- [x] TinyMCE plugin: [textcolor](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/textcolor)
- [ ] TinyMCE plugin: [wordpress](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/wordpress)
- [ ] TinyMCE plugin: [wpautoresize](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/wpautoresize)
- [ ] TinyMCE plugin: [wpdialogs](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/wpdialogs)
- [ ] TinyMCE plugin: [wpeditimage](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/wpeditimage)
- [ ] TinyMCE plugin: [wpemoji](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/wpemoji)
- [x] TinyMCE plugin: [wpgallery](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/wpgallery)
- [ ] TinyMCE plugin: [wplink](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/wplink)
- [x] TinyMCE plugin: [wptextpattern](https://github.com/ClassicPress/ClassicPress/tree/develop/src/wp-includes/js/tinymce/plugins/wptextpattern)
- [x] #72
I’m also curious - what is the reasoning behind naming this plugin “ClassicPress Editor”? I would think the ClassicPress Editor is the one that’s already shipped with ClassicPress.
3 Likes
This doesn’t need to work with Enriched Editor, necessarily. It could completely negate the need for it.
3 Likes
I thought the intent was to create the plugin as a research project, hammer out any issues there, and then ship it with core when it was ready. When/if it ships with core, it will be the ClassicPress Editor.
4 Likes
Do any of the CP tests cover the editor?
2 Likes
Wow, while I’m sleeping over here, you are making huge progress! Great work @anon71687268
I’ll be in for testing it when you have something.
3 Likes
It is a proof of concept, tests are a great thing to be added though and if anyone can help there that would be amazing
1 Like
wadestriebel:
It is a proof of concept
Yes, but the comments in the referenced WP tickets indicate that there are core tests. I just didn’t know if those tests were added after the fork or not.
3 Likes
Thanks. The PR was already approved. Feel free to give it a go and note any issues you find.
2 Likes
Feedback/issues should be posted to GitHub. Otherwise, this thread’s going to be miles long.
3 Likes
This is great guys. Can’t wait for a version that the rest of the community can test.
2 Likes
The rest of the community is free to test it. It takes a village.
1 Like
i mean a beta version, or something like that…
anyway, i’ll think about creating an account in GitHub so that i can jump in…
4 Likes
Wow, that’s pretty cool @anon71687268 - Congratulations for being amazing.
Such a good organization is really motivating. I will convince some friends who use WP for their blogs to make the change to CP.
Also, I will test your plugin and see if I can collaborate with this, got some free time the following days.
As you mentioned, if I find something useful I will open a GitHub issue about it.
4 Likes
james
August 30, 2021, 1:55pm
60
1 Like