Found several typos and such in CP v2 strings

[Guido07111975]

Hi,

While translating CP I found several typo’s and such in CP v2.3.1

Develop branch:

wp-admin/about.php:136
Release Announcements subforum = Release Notes subforum

wp-admin/options:314
The link is not wrapped in link (a) tag. Change into:
See <a href="https://developer.wordpress.org/plugins/settings/settings-api/">documentation on the Settings API</a>
(or copy-paste code from the WP file)

wp-admin/theme-install.php:113
ClassicPress Theme Directory = WordPress Theme Directory
(this string is about the WP repository)

wp-admin/plugin-install.php:97
ClassicPress Plugin Directory = WordPress Plugin Directory
(this string is about the WP repository)

wp-admin/themes.php:156
ClassicPress Theme Directory = WordPress Theme Directory
(this string is about the WP repository)

wp-admin/plugins.php:549
ClassicPress Plugin Directory = WordPress Plugin Directory
(this string is about the WP repository)

wp-admin/includes/class-wp-automatic-updater.php:1439
The mail content for Beta Testing CP starts here. Including 2 links (to support forum and trac), but they link to WP instead of CP.

[timkaye]

Thanks for this report: excellent work!

I have now opened a PR to correct all these issues at Admin typos by KTS915 · Pull Request #1720 · ClassicPress/ClassicPress · GitHub

[Guido07111975]

You’re welcome! I do have a question about:

wp-admin/theme-install.php:113
wp-admin/plugin-install.php:97
wp-admin/themes.php:156
wp-admin/plugins.php:549

It was my understanding that those strings are about the WP repository, not the CP one? Because themes/plugins from the WP repository are listed there.

[timkaye]

I would say that it makes sense to use those strings to direct people to the CP Directory, especially now that it’s not at all clear that access to the WP repository is going to be open to everyone for much longer.

[Guido07111975]

True… A lot of trouble over there, unfortunately…
Hopefully the ClassicPress Directory Integration plugin will be included by default in a future version of CP.

Guido

[Guido07111975]

Hi @timkaye

And these are still mentioning WP instead of CP:

wp-admin/includes/dashboard.php#L1651
wp-admin/includes/dashboard.php#L1664
wp-admin/themes.php#L132

[timkaye]

Thanks; now added to PR!

[Guido07111975]

Forgot one:
wp-includes/update.php:666

[Guido07111975]

Hi Tim,

Found a few more.
Can you add them to your ticket or do you prefer that I open my own?

Guido

[timkaye]

As you now have a Github account, it makes more sense for you to create a new PR yourself.

[EliteStarServices]

On the subject of GitHub.
I know part of what it does is allow multiple devs to work together, but that also seems to be where I struggle the most. I (try to) use VSCode as my interface with GitHub and it works great until a conflict exists. Even when I go to GitHub I am not confident at all when trying to ‘fix’ those conflicts. So far Simone has helped me some, but I need to work through that somehow.

[timkaye]

I just copy and paste my code from my text editor (Geany) into GitHub.

[EliteStarServices]

VSCode provides a clean interface between my local dev copy and my fork on GitHub. If my PR has no conflict, then everything goes fine, but if there is a conflict, that is when I have trouble.

I can sync my GitHub fork with the master, then try to work out the conflicts between GitHub and my local copy - or I can update GitHub from my local copy and then try to work out the conflicts when I create the PR, but in both cases I tend to run into problems getting it worked out.