I wrote a theme

Frank419 · August 28, 2024, 10:32am

I just wrote a theme:

It was on the WordPress theme trac right now, but wasn’t approved yet. I feel like share it here so I did

ElisabettaCarrara · August 28, 2024, 1:08pm

Try submitting it to directory also.

Frank419 · August 28, 2024, 1:14pm

This one?

I don’t know why but I had trouble registering with it right now. The first email never arrives — further emails only brings me to “Your password reset link appears to be invalid. Please request a new link below”.

ElisabettaCarrara · August 28, 2024, 1:20pm

yes, exactly that one.

ElisabettaCarrara · August 28, 2024, 1:21pm

about the link problem, it happens with firefox and firefox based browsers. you have to copy the link and past in a new tab OF THE SAME BROWSER to make it work. It’s the browser that strips things from the link.

Frank419 · August 28, 2024, 1:23pm

Gosh, I wish that I know this earlier, now that even the reset password email didn’t come

ElisabettaCarrara · August 28, 2024, 1:26pm

try waiting for a little time, it should work then. There is no rush.
One thing you can do is add these workflows to the theme repo (they help in making the theme or plugin compatible and ready to be accepted in the directory).

ElisabettaCarrara · August 28, 2024, 1:31pm

I installed the theme, I can safely say that I very much like it and it works in CP (with debugging enabled it only throws a deprecation regarding the add_theme_support() for html5 that was deprecated in CP and it’s pretty much irrelevant because it does not hinder the theme from working as intended, usually i just comment out that function in the file to avoid the nag while developing a site).
I am redesigning my own site to look more vibrant and feel less dated. Your theme seems really the right fit.

Frank419 · August 28, 2024, 1:33pm

Thank you for the kind words! (Actually I’ve having much trouble making it live on WordPress theme directory.)

I’m trying to reset the password again and see if it works.

Frank419 · August 28, 2024, 1:56pm

I’ve just uploaded it to the CP directory. May I please know what is the review process?

ElisabettaCarrara · August 28, 2024, 2:15pm

usually the theme or plugin gets reviewed and in case it does not pass the standards set for the directory you get an email with further instructions from the review team.

If you use the GitHub actions I linked above the chances it gets rejected are very small.

Frank419 · August 28, 2024, 3:11pm

Wait. You linked something above? I’m afraid that you forgot to actually link it.

ElisabettaCarrara · August 28, 2024, 4:37pm

sorry link got lost that is it.
These are CPCS (CP coding standards) and an action that creates the zip release for the directory.

Frank419 · August 29, 2024, 12:19am

I just configured the workflow and I can say that it was more in depth than the theme check plugin, but I think there’s still something wrong with it, for example it claims variables like $tag,$id,$post_id are WordPress globals while they’re not as far as I know.

ElisabettaCarrara · August 29, 2024, 3:49am

I am not well versed with all its intricacies since I started using it not so long ago.

@Simone is the expert here. As far as I know CPCS is a modifies version of the WP coding standard checks and it should work similarly to it, if I am not wrong.

I think it can be improved upon by tweaking the .yaml file to be more suitable for CP.

Simone · August 29, 2024, 6:29am

Taking as example this line:

github.com

onmyodev/MinimalistFlex/blob/6db67ae28bc996f8f42f0200d61d1fada57d77cb/templates/loop.php#L14


      
          }
          ?>
          
          <?php
          $default_images = explode( ',', get_theme_mod( 'minimalistflex_default_featured_images' ));
          $default_image_location = get_theme_mod( 'minimalistflex_default_featured_images_location', 'archive' );
          ?>
          
          <?php while ( have_posts() ) :
                  the_post();
                  $id = get_the_author_meta('ID');
                  $post_id = get_the_ID();
              ?>
              <div <?php post_class("panel"); ?>>
                  <?php if ( has_post_thumbnail() ): ?>
                      <a class="panel-image" href="<?php the_permalink() ?>" aria-label="<?php
                      printf(
                          /* translators: %s: Post title associated with the thumbnail image. */
                          esc_attr__( 'Thumbnail image of %s. Also a link that navigates to it.', 'minimalistflex' ),
                          get_the_title()
                      ) ?>">

If you check $id before assigning a value, you can see that is globalized somewhere, so better using something like $my_id. CPCS is not wrong there.

But in some cases it can throw false positives, and so you can bypass CPCS in this way:

// I'm sure this is not a global
$id = get_the_author_meta('ID');  // phpcs:ignore  WordPress.WP.GlobalVariablesOverride.Prohibited

Frank419 · August 29, 2024, 7:25am

Thanks for the reply!

Actually I just identified some bugs and is currently working towards those first. Since they are actually globals, I think I would add prefixing to variables just like functions.

Just fiddled with the codes and now all the tests are passed! How do I submit the update by the way?

Simone · August 29, 2024, 8:05am

When a new version is released the directory will catch it.
But anyway ping me so I’ll make sure that the link will be updated.

Frank419 · August 29, 2024, 9:13am

I just published a new release on GitHub.

Apparently, the auto packaging workflow doesn’t run because of being really outdated, and well, the directory didn’t catch anything.

Can you please update the link (although it was still in review)?

@Simone pinging in case that the reply didn’t trigger notifications.

Simone · August 29, 2024, 1:07pm

Directory catches updates using a cron job which may not yet have been executed.
I’ve manually updated to v1.0.5.

For the auto packaging, try this:

open repo Settings
open Actions > General tab
Give Read and write permissions in Workflow permissions