Implement a coding standard

[discobot]

WordPress has their own php coding standard for core. Although far from all code in core actually follows the standard.
I would love for ClassicPress to follow industry standard PSR-2.

---

Read-only archive: Issues · ClassicPress/ClassicPress · GitHub

Author: Joi Glifberg

Vote count: 17

Status: Completed

---

Comments

Definitely gets my vote, but it’s a huge job and it’d make merging changes from WP harder.

~ posted by invisnet

@invisnet Agreed, but there’s automated tools that can help migrate big parts of the core. Another option would be to only allow PSR-2 in newly committed code.

~ posted by Joi Glifberg

When we move to v2 we will have more flexibility here, for example, we could begin converting individual plugins to PSR-2 without causing (more) difficulties when porting changes back from WordPress.

Joi: please elaborate about the automated tools. In my experience these tools (phpcs) are far from perfect, especially with codebases that contain a lot of “historical oddities” like WordPress/ClassicPress.

~ posted by James Nylen

Generally, I would love to see WordPress code be updated to modern standards and away from the decade-old hooks and bloated php calls.

~ posted by Ed Sutherland

Is this petition about only using an autoloader (PSR-2)?

~ posted by William Patton

I wouldn’t think so, William… a coding standard should cover everything right down to spaces vs. tabs.

~ posted by Code Potent

Would you consider PSR-4?

~ posted by Laurence Bahiirwa

PSR-2 has been deprecated and PSR-12 is recommended now.

~ posted by stefanos82

[anon66243189]

PSR-anything includes standards that aren’t security related and as a matter of fact wpcs is using partially psr2 rules.

A recent poll has shown folks are worried about their freedom if we enforce any standard really that isn’t about pure security

As much I’d like a standard we should stick to wpcs in core, and “security only” in plugins + themes
This work (for plugins and themes) is underway now

I think this can be closed therefore

[anon66243189]

@viktor actually we do now have a coding standard for Plugins/Themes approval, and the core is anyway following coding WPCS standard (mostly) and a number of other standards which are way more advanced than PSR_x standards.

We should either close or mark as done I think, so folks do not waste votes on it.

[viktor]

One reservation I have about closing this petition right now is the original intent. What you described is basically what the petitioner described is the problem:

WordPress has their own php coding standard for core. Although far from all code in core actually follows the standard.

So the petition asks for one standard across all core files.

[joyously]

There is a branch for the big PHP coding standards changeset. The build does run the coding standard checks, but a lot of them fail until that changeset gets merged.

@viktor

So the petition asks for one standard across all core files.

WP added a JS coding standard, but hasn’t made all the existing JS match it. I don’t think having the same standard for PHP and JS is optimal, or what the petition is asking for.
I think the petition should be closed.

[timkaye]

I also think this petition should be closed. @MattyRob has already got the ball rolling on this.

[viktor]

Closing.