Implement a coding standard

[discobot]

WordPress has their own php coding standard for core. Although far from all code in core actually follows the standard.
I would love for ClassicPress to follow industry standard PSR-2.

---

Read-only archive: https://petitions.classicpress.net/posts/174/implement-a-coding-standard

Author: Joi Glifberg

Vote count: 17

Status: open

---

Comments

Definitely gets my vote, but it’s a huge job and it’d make merging changes from WP harder.

~ posted by invisnet

@invisnet Agreed, but there’s automated tools that can help migrate big parts of the core. Another option would be to only allow PSR-2 in newly committed code.

~ posted by Joi Glifberg

When we move to v2 we will have more flexibility here, for example, we could begin converting individual plugins to PSR-2 without causing (more) difficulties when porting changes back from WordPress.

Joi: please elaborate about the automated tools. In my experience these tools (phpcs) are far from perfect, especially with codebases that contain a lot of “historical oddities” like WordPress/ClassicPress.

~ posted by James Nylen

Generally, I would love to see WordPress code be updated to modern standards and away from the decade-old hooks and bloated php calls.

~ posted by Ed Sutherland

Is this petition about only using an autoloader (PSR-2)?

~ posted by William Patton

I wouldn’t think so, William… a coding standard should cover everything right down to spaces vs. tabs.

~ posted by Code Potent

Would you consider PSR-4?

~ posted by Laurence Bahiirwa

PSR-2 has been deprecated and PSR-12 is recommended now.

~ posted by stefanos82