Issue with Dark Theme Code Blocks

Putting this here so I remember to fix it when I get a chance.

@invisnet reported issues with the Dark Theme code blocks.

Looking at 2 plugins for CP the code block is using white on white.

3 Likes

Fixed for now, I think it could use some fine tuning though:

1 Like

How about making the background color the same as for “normal” quotes? I think it will look really nice after that.

Perhaps just me (and I don’t use the dark theme, so, this is simply informational,) but, I can’t read the variables at all. I know they’re there as that was from something I posted, however, they look like off-color blotches under the proposed color scheme; it’s not even readily apparent that those are textual characters.

Thoughts?

Now it’s the-same-thing-in-reverse. I can read everything if I strain hard, but the color used for (e.g.) ob_start(); is exceptionally trying on that background. Again, take this with a grain of salt as I don’t even use the dark theme.

We can remove the first change:

And I don’t use it either, @invisnet thoughts?

2 Likes

Well, now… I can see everything in this latest render… it must look absolutely terrible to everyone else. :smiley:

2 Likes

I think it looks okay - it is code so it shouldn’t be pretty to look at, right? :wink:

I will mark this as solved for now, we can continue to fine tune if we hear from anyone else :slight_smile:

2 Likes

That looks very good to me. The part with the lowest contrast ratio is probably the return and eval now, but it is still easily readable.

2 Likes

That’s looking good now - thanks!

2 Likes

This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.