the new version of the file will need to be pushed out into your own plugins at some point . The old file remains compatible with the new version of Update Manager; no breaking changes.
So, since we didn’t need theme support I didn’t worry about it.
I was thinking more of having it in a place where someone like me might easily find it. I don’t tend to delve too deeply into code.
Hahaha… I guess you’ve arrived at that at some point point! I suppose the version number could be added to the top of the file in the code comments – is that what you meant?
Yep, exactly. That would make checking really quick and easy.
I should have known it was important… it was in italics!
Well, at least we now know that @anon95694377 isn’t trying to hack into everyone’s plugins and gradually infiltrate the entire ClassicPress environment.
I’ve created an issue for this. Note that it probably won’t get added for some time; it’s a rather inconsequential change to push out as a point release. But, at least it won’t be lost.
Hmmm… I just copied the new 2.0.0 client file into my test site, configured the variables as before and it still does exactly the same thing. Zigpress header is replacing CC header.
And it does the same thing on my Utility plugin. And that one does have the latest version of the Update Client installed. Might need to remove that “solved” tag @anon71687268.
Just a bit of extra info. I’ve got a site with both Classic SEO and Classic Commerce installed and the plugin details display correctly for both.
So, I installed ZP Image Control and activated it but did not look at the plugin details.
When I looked at the plugin details for Classic SEO, I also got the Zigpress banner, so it can’t be a cache issue as I’ve never loaded the Zigpress banner before.
I think it may possibly be to do with CSS and/or the loading of filters.
When I have the details popup open for Classic SEO (with ZP Image Control active), this bit of CSS is in the frame source:
The function get_plugin_images in the update manager class provides the filters, but filters in WordPress are global so you have more than one plugin competing to change the filtered data.
So maybe the filters need to be renamed so that they contain the plugin slug or something?
EDIT: Hmm, not sure if I’m right actually, considering there’s a namespace involved.
Sorry if my answer is wrong but i’m checking it all over mobile. When using filters provided by update manager for assets you must check if the initial value deals with your plugin (search for plugin slug inside path).
Changing the image dir globally will result in changing it for every plugin using UM. Namespaces are not involved in this process.
Thanks all for rooting out the issue and coming up with a workaround. I’m not at my workstation, but, will take a closer look at solving this at the root in the coming week. I’ll keep you posted.