@Joy_Reynolds: Hey Matt, what’s up for today?
@Matt_Robinson: Hello Joy.
I was just pondering that same question. Unfortunately, life has taken over for myself and Wade in the last week and as I’m sure you’d noticed we have still not found a mutually convenient time to make a release.
@Matt_Robinson: Hopefully this weekend…
In terms of the core code then there is not a great deal to accomplish today in merging. We could perhaps look through the 1.5.0 milestone and get some reviewed for quick merge once we do manage to ship 1.4.2
@Joy_Reynolds: OK, can you see who has access to change labels or move stuff to milestones?
@Matt_Robinson: That area of GH is new to me - but I think I can yes - would you like access to that level?
@Joy_Reynolds: I don’t really want access, but it would be good to know who has it so we can get them involved more often.
@Viktor: I think I’ve seen Laurence doing some housekeeping on GitHub.
@Joy_Reynolds: You can make a Slack alias for those people and then ping the alias for meetings?
@Matt_Robinson: It looks currently like me, Laurence, Tim and Simone - I think they are all already on Slack too.
@Joy_Reynolds: Perhaps Viktor can make an alias here.
@committers a lot, but that’s not exactly what this is.
@triage or something.
So, PRs destined for 1.5?
@Matt_Robinson: That fits well as the permission level to manage labels and milestone in GH is called ‘Triage’.
If we can look at some of the PRs listed:
If we are happy we can add the ‘Community Reviewed’ label and maybe a commit that they are fine to commit early in the 1.5.0 develop cycle.
@Joy_Reynolds: Won’t each need a refresh? Or how does Git treat that?
@Matt_Robinson: GitHub will report if there are any conflicts that need resolving, so it may well not be necessary to update.
@Álvaro_Franz: I can help at this time. But I don’t know where to start.
Or what to do.
@Joy_Reynolds: Oldest is from 2019.
@Matt_Robinson: One I’m just looking at we have noted already is a duplicate:
@Joy_Reynolds: Same fix?
@Matt_Robinson: Yes, same fix. The earlier one needs the indentation and I can do that simply as it is mine. The second one fixes the indentation but I think is incomplete in that regards.
I propose I push an update to mine and close #1006 with a link between the two PRs.
@Joy_Reynolds: This milestone contains issues and PRs. But some of the PRs have a label of “has PR”.
Does Alvaro want access to do labels and milestone stuff?
@Viktor: @Matt_Robinson is there anything Alvaro can start working on? Any pending issues on Github?
[June 30th, 2022 11:22 AM] alvaro.franz: I can help at this time. But I don’t know where to start.
@Matt_Robinson: @Álvaro_Franz - if you are happy and can share your GH handle I can add you as a triage member. Testing of the PRs in the 1.5.0 milestone would be a good place to start if that sounds okay.
@Álvaro_Franz: Sure, that’s a good start, you can add 3v-afranz. What’s the approach I have to take to test PRs?
Merge them locally and see if I find issues?
@Matt_Robinson: How about https://github.com/ClassicPress/ClassicPress/pull/896 - that looks like it might fit in your area of expertise @Joy_Reynolds
@Álvaro_Franz - invite sent
@Joy_Reynolds: Reread the contributing doc, it’s linked at the top of this channel.
@Matt_Robinson: If you have a local fork of the ClassicPress code, and you can run it as a local host testing advice is here:
@Joy_Reynolds: Matt, did you find a way to make sure you got everything related to a feature, like the lazy loading stuff?
I know WP added lazy load iframe, and had some issues with it. I guess they were fixed later. Did we want iframes lazy or not?
@Matt_Robinson: It is an entirely manual process - part if it is making sure you have all of the commit on a WP ticket but when issues are added and a new ticket is opened upstream to fix that issue it very much relies on us finding or realising that there is that issue.
@William_Patton: Lazy loaded iframes aren’t fully supported in safari without turning on a flag. All other major browsers work with it.
@Joy_Reynolds: I know they added a filter to count images, so that they wouldn’t put lazy on the images “above the fold”.
@William_Patton: Is that part of what caused issues on WP side do you know?
@Joy_Reynolds: I am not that familiar with the issues for iframes. I just saw it in passing.
@William_Patton: Gocha, I’ll try ask someone on the WP side if they remember.
Probably sergey wrote the code and commited it so I’ll start there
@Joy_Reynolds: William, did you want some access to the repo? Triage at least?
@Matt_Robinson: The ‘above the fold’ stuff is in this upstream ticket and the changeset is added to the existing backport:
Backport of 52065 has also been added to refine this further.
@Joy_Reynolds: There’s a question there about the deprecated function call.
I don’t know the policy.
Do we say deprecated in WP 5.5 or CP 1.5?
@Laurence: WP-5.5 is appropriate. We would say CP-1.5 if the change is in ClassicPress alone as the source.
@Matt_Robinson: I’m trying to make sense of that as the function associated with that query isn’t part of the backport but got pulled in. I suspect I manually fix the backport - the question is still valid though - and I think if we are backporting a change from WP that implemented the deprecation we should reference WP. If we decide to deprecate something that we added in CP that was never upstream then it should be the CP version.
We have quite a few people attending today, so I’d like to spend what time I have left opening the floor to the audience to see if there are any questions or comments.
@Viktor: There’s an older PR to remove IE11 support. Last thing it needed was grunt precommit: https://github.com/ClassicPress/ClassicPress/pull/838
<https://github.com/ClassicPress/ClassicPress/pull/838|#838 WP-r50784: Build/Test Tools: Remove Internet Explorer 11 from the
Is that something we can finish?
I couldn’t do it since grunt stuff was not Windows compatible.
@Joy_Reynolds: Can you add a little to the Contributing doc to give the next steps when testing a PR? Or if it is just repeating the steps from “checkout” step, mention that. It is confusing how to tell what your local contains and how to reset it to test a separate PR.
@Matt_Robinson: @Viktor - I remember that now and I never got around to it - I’ll take a look.
@Joy_Reynolds: I think WP didn’t actually remove everything that relates to IE support…
@Viktor: The issue does have more work to be done, but that specific PR is for a changeset and should be completed. It won’t complete the issue, though.
@Joy_Reynolds: When would be a good time to chat about trying to go backwards from WP 6.0?
Should we have a meeting about the plugin/theme directory?
@Matt_Robinson: A plugin / theme meeting would be good - not sure if there is someone leading on that as I know virtually nothing about it at the moment.
@Viktor: I think we had it before. I’ll create directory channel.
@Matt_Robinson: There is already on called plugins
@Joy_Reynolds: That’s different. and there are themes too
@Matt_Robinson: Maybe #directory?
@Laurence: Well said @Joy_Reynolds. That is to help devs discuss plugins.
@Joy_Reynolds: What I don’t want is to carry over from WP the bad version of theme API.
@William_Patton: I think that for the baseline it would need to be 1:1 compatible. The bad parts as well
@Joy_Reynolds: I’ve been pushing at WP to get
Update URI for themes. It has been neglected though.
@William_Patton: Maybe we can remap the bad/good parts server side though with the idea to move to a better set of endpoints as a next version on the themes API.
In a perfect world both theme and plugin APIs reach a good point of similarity rather than being separate things of their own?
@Joy_Reynolds: Yes, I don’t see why the API would be different.
@William_Patton: The WP one is kinda different XD
Built in isolation is probably the cause of that. Since we are building fresh we can account for the similarities in one swoop
@Joy_Reynolds: Yes, they are different now, but I don’t see why they should be for CP. Make the theme one like the plugin one, which has more.
@Álvaro_Franz: Quick question, any specific PR that needs review ASAP, so I do it now?
@Laurence: I think @Wade_Striebel had a well thought out and simplified approach to devs using their GitHub repos. We can borrow from that and provide the same concept for themes and plugins with different endpoints
@Joy_Reynolds: Yes, that’s where the
Update URI comes in.
You simply filter it and core does the rest.
@Matt_Robinson: @Viktor I manage to get the IE11 PR updated and passing now. Might just need a quick manual test with the CSS changes.
Thanks to everyone for one of the most lively PR sessions in a long time.
@Viktor: FYI, I want to try publishing meeting transcript in the forum again. So our community can keep track of the progress.