View in #core on Slack
@Matt_Robinson: It is time for the weekly PR meeting. Who’s online?
First up is:
https://github.com/ClassicPress/ClassicPress/pull/1135
Has had good community review and looks to be a good way to improve Issue reported on GH.
@Simone_Fioravanti: I like that!
@Matt_Robinson: @Simone_Fioravanti - looks like you reviewed, are you able to manage labels on PRs?
@Simone_Fioravanti: Yes. I haven’t removed the needs 2nd because you were asked to review.
@Matt_Robinson: That shouldn’t stop you and if you add a review it makes my life easier!
@Simone_Fioravanti: I’ve left that also on #1124 because it was missing Tim’s review.
@Matt_Robinson: Merged. I noted you also reviewed these two:
https://github.com/ClassicPress/ClassicPress/pull/1117
https://github.com/ClassicPress/ClassicPress/pull/1102
And that you made a build and have tested on your own sites.
@Simone_Fioravanti: No build, just tested. It’s already running with those two without errors.
@Matt_Robinson: Happy if we merge and I can then start looking at the next batch of backports?
Then we can look at 1124 too, it seems fine to me.
@Simone_Fioravanti: I’ve tested 1124 a lot…
Next backport is WP-r49542?
@Matt_Robinson: Do we have a PR for that yet?
@Simone_Fioravanti: No, I asked because it fixes that bug in the home page that’s really annoying.
Also the quick fix from wp-cms was deleted.
@Matt_Robinson: Ah sorry, with you now 49542 is a ticket with about 37 commits to backport. As you say it includes a PHP8 fix that we did have a ticket for. That closed when the fork or branch was deleted
I know about that though so it will get picked up in the work from that ticket.
We did have issues earlier this week with the Renovate Bot too. There is a Commenter script running on one of James Nylen’s servers that has broken and was leaving repeated comments on any Renovate PRs. For now Renovate is suspended while we try to reach James.
In merging som of the issues found I managed to break the Welcome message for people posting a first Ticket, I’ve updated to a current GH Action and that now seems to be fixed and working again.
So we are okay for the moment but need the Renovate Dependency checker working again at some point.
@Simone_Fioravanti: I’ve never worked with that bot, so can’t help on that, but sure we need it working again.
@Matt_Robinson: It took me a while to figure out too
Okay, so 1102 is merged and tests are running. It looks like I have some conflicts to fix in 1117 before that can merge. So maybe 1124 is next up so that can merge and be testing while I start looking into 1117.
@Simone_Fioravanti: Good to merge 1124!
You’ll find very few conflicts merging 1117.
@Matt_Robinson: #1124 is merging, I think 6 files with 1 or 2 issues per file - not too bad.
Anything else in the 1.5.0 milestone we can progress today?
@Simone_Fioravanti: 1133 is very simple…
PHPmailer upgrade
@Matt_Robinson: Do you think we can / should close this Issue?
https://github.com/ClassicPress/ClassicPress/issues/1049
We have Unit tests running on PHP 8 and 8.1 right now.
I can merge 1133 later if that one is agreed.
@Simone_Fioravanti: Yes I agree
@Matt_Robinson: Hmm, looking at the GitHub actions it seems we have some steps that need an update, message says:
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: styfle/cancel-workflow-action, actions/setup-node, actions/cache, actions/checkout, actions/checkout, actions/cache
I’ve looked very briefyly at actions/setup-node
and we are on v1 when the current release is v3. I’ll see if I can find time to work through these and create and update PR.
@Simone_Fioravanti: We have two other PR that are quite easy but miss the 2nd review: 943 and 1129.
@Matt_Robinson: Both of those look like clean and simple changes checking the code, I’ll leave a browser window open on those and merge later.
@Simone_Fioravanti: Ok! About actions… what is broken?
@Matt_Robinson: Nothing is broken yet, just deprecation notices for Node 12.
Anything else for this week?
FYI, I won’t be available next week and maybe not the week after either.
@Simone_Fioravanti: Nothing else from me…
@Matt_Robinson: Great, thank you for your assistance today - I feel we got a good chunk of things done there.
@Simone_Fioravanti: Thank you!