View in #core on Slack
@Matt_Robinson: Anyone else around for a short review meeting this week?
@Joy_Reynolds: I’m here
@Matt_Robinson: I was thinking or trying to finish off the 1.4.4 release today, but as it’s a release and I’m somewhat jet-lagged it needs care and some good checking - shall we?
@Joy_Reynolds: How does the security release fit in with that?
Or that’s what you meant?
@Matt_Robinson: Next planned release is 1.5.0 so 1.4.4 is the security release and I think the release hotfix process takes a starting point of 1.4.3,
@Joy_Reynolds: OK, just catching up…
I don’t know the process for security updates.
@Matt_Robinson: I’m still learning this too, but the release process is pretty automated and includes a step to add additional patches in the middle of the process. I’ve started things and created a forum post ready and kicked off the release process about 10 days ago including a backport of changeset 54569 - I’m at the stage where this is ready to push to
master branches. This is where I’m going to need the double check that the code changes look about right.
@Simone_Fioravanti: Ok so if you push to
master we can have a look to the changes, right?
@Matt_Robinson: Yes, and there should be a diff we can view too.
@Simone_Fioravanti: Ready to checkout
@Matt_Robinson: Push has been made and diff for review is here:
Need to compare that to:
@Joy_Reynolds: One consequence that this set of changes had at WP was that the CSS filter removed
object-fit, so they have a patch ready to add
object-fit to the list of valid CSS properties. They haven’t had a release yet to include that though.
@Matt_Robinson: As a minimum there are some docblock
WP- prefixes missing. If there is a commit made about the
object-fit issue we can backport that later unless you think it a big enough issue to wait.
Although, where does it remove it from? Is it from Block attributes, Theme editor or just content filtering?
@Simone_Fioravanti: A quick try on a live site gives no errors.
safecss_filter_attr doesn’t have
object-fit and apparently it is now applied in more places (likely in blocks for WP), but CP should have all the valid CSS properties anyway.
@Matt_Robinson: Okay, so it seems not a blocking issue.
@Simone_Fioravanti: Comparing not against track but against GitHub https://github.com/WordPress/WordPress/commit/affa0e3fe7b676f4d28a1d276299d20ae76df704:
Some differences in:
But can’t understand if this is fine.
And as you said, since is missing WP- in dockblock.
wp-includes/functions.php - that looks like the backported fix to me:
@Joy_Reynolds: I compared the changes in Git to the changes in Trac and they seem to match.
@Matt_Robinson: Same for the
Thanks Joy, if you think it looks about right that is reassuring.
Some of the changes seem to apply to the RSS and Widget blocks as listed here:
@Joy_Reynolds: These were all opened because of the
object-fit being stripped. They are duplicates, and about a block, but the security changes now filters the CSS more, so we should have it in there.
#56890 (Post Featured Image always using Fill scaling.) – WordPress Trac
#56888 (Thumbnails images stretched after 6.0.3 update) – WordPress Trac
#56881 (V6.0.3 Post Featured Image block - Scale feature always defaults to Fill even if Cover or Contain selected) – WordPress Trac
#56872 (i have problems with featured image) – WordPress Trac
#56855 (Featured Image bug in 6.0.3) – WordPress Trac
@Simone_Fioravanti: Sorry, my fault! Looks fine!
@Joy_Reynolds: If there is a change for a block, it’s in code that CP has? Or the change added code we don’t need?
Some of the core blocks simply refactor widgets.
@Matt_Robinson: No, any changes that applied to Block code will be missed as they are either in files we don’t have or have been pulled out of sections of code we don’t have (usually manually).
Okay, I’m going to start the build locally now.
@Joy_Reynolds: Are you putting in
@Matt_Robinson: I’m was planning on backporting that later and get it in
1.5.0 , it’s 4 commits and the ticket is still open for backporting.
@Joy_Reynolds: https://core.trac.wordpress.org/attachment/ticket/56855/56855.1.diff is a test case for it.
@Matt_Robinson: Build zip should be available for testing here:
@Joy_Reynolds: Do we test something in particular?
@Simone_Fioravanti: Seems good! Testing on 2 sites…
@Matt_Robinson: Installing it fresh and general use.
I’ve spun up a fresh site and made a post, brief load of a few admin pages looks okay.
@Simone_Fioravanti: I see strange things in the last commit on
@Joy_Reynolds: Trying to see what to test, here are the files changed:
src/wp-admin/includes/ajax-actions.php (1 diff)
src/wp-admin/includes/post.php (1 diff)
src/wp-includes/class-wp-query.php (5 diffs)
src/wp-includes/comment.php (2 diffs)
src/wp-includes/customize/class-wp-customize-header-image-control.php (1 diff)
src/wp-includes/customize/class-wp-customize-site-icon-control.php (1 diff)
src/wp-includes/date.php (3 diffs)
src/wp-includes/deprecated.php (1 diff)
src/wp-includes/functions.php (3 diffs)
src/wp-includes/media-template.php (1 diff)
src/wp-includes/pluggable.php (1 diff)
src/wp-includes/post.php (2 diffs)
src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php (1 diff)
src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php (2 diffs)
src/wp-includes/widgets.php (2 diffs)
src/wp-mail.php (2 diffs)
src/wp-trackback.php (1 diff)
@Matt_Robinson: Simone, what strange things are you seeing - I’ve noted the
phpcs action is erroring, I can probably track that down and fix it but as it’s a code layout issue it’s not really a release blocker.
@Viktor: Running on one of my production sites, all is good so far.
@Simone_Fioravanti: Sure… it’s not blocking the release. I see a lot of chmod and empty files. Don’t know what it means.
@Matt_Robinson: I think that might be image files using slightly different compression as I’m on MacOS
@Simone_Fioravanti: Was looking at this https://github.com/ClassicPress/ClassicPress/commit/b8cbe4deefb30eb2c02a93a0c4602787993a5121
Yes I see the images thing.
@Joy_Reynolds: So, Git says it’s showing 151 changed files, but they have 0 changes?
@Matt_Robinson: Anyone know how to change the date of a post of the forums?
Where is that Joy?
@Joy_Reynolds: It’s what is in the link Simone pasted just above.
@Matt_Robinson: Look back more than that one commit and there are the changes:
@Simone_Fioravanti: Yes, I see them all, just can’t understand that
chmods. But don’t know if it is not important.
@Matt_Robinson: Ah, I did that locally to get the unit tests running yesterday. It’s a CHMOD to 777 so risky, I’ll revert it in
I can’t see anything else in the last commit that is anything do with the last release so will revert and push that change as soon as I can.
Okay, the release is now completed, I’ve also reverted that last change in the
The thing I have to remember to do is the
object-fit backport and add that to the 1.5.0 milestone. I think that was all.
Thanks to all for you help making this release today - with the jetlag I could not have done it without you :rolling_on_the_floor_laughing:
@Simone_Fioravanti: Thank you