View in #core on Slack
@Matt_Robinson: Time for the weekly core meeting - apologies for not noting the UTC time change earlier due to changes to DST. Any one else around with some time to spare?
@Joy_Reynolds: Did the time change somewhere?
@Matt_Robinson: It did in UK where I live, last weekend.
@Simone_Fioravanti: Hi! Same here.
@Joy_Reynolds: OK. I wondered when it would, but haven’t made the time to look it up. It hasn’t changed here yet.
@Matt_Robinson: I get lost with time zones in general and even more when times change within a timezone. Makes it worse still as I’m in GMT / UTC timezone so to me it’s seems simple until other areas offset come into the equation. So for about the next six months the meeting will be UTC 1600. (I think)
First up is a reflect on the 1.4.4 release. I reverted the permissions changes to the wp-content
folder in core ready for subsequent release. Other than that it all seems to have been relatively smooth. We have a PR to enable migrations to 1.4.4 for newly migrating sites:
https://github.com/ClassicPress/ClassicPress-APIs/pull/57
I would suggest that it good to merge.
@Joy_Reynolds: also, an issue with the version of the wp_version
@Simone_Fioravanti: Good to merge for me.
@Matt_Robinson: I’d seen the core PR for that, not looked in any more detail but I suspect it’s an easy change and can be merged for 1.5.0.
While on the APIs, we can also enable migrations from WordPress 6.0.3 or 6.1. I have tested both briefly and didn’t see any major issues. Anyone else had a look?
@Joy_Reynolds: What do you look for?
@Simone_Fioravanti: It’s just one line if I’ve not missed other places where the version is defined.
@Joy_Reynolds: There are more files in 6.1, I think.
Is anything done in migration with block themes? (I guess these didn’t exist back when James was doing all this migration stuff.)
If a person migrating had a block theme active, what would happen?
@Matt_Robinson: The Migration plugin does check for known incompatible themes. On checking my local switch
setup, there are files included from WordPress 5.5 that are not removed during migration.
@Joy_Reynolds: I would guess that a block theme would not have what CP considers required for a theme, and it would switch to a fallback from the list bundled with CP.
@Matt_Robinson: No, migration os blocked until the theme is changed.
@Joy_Reynolds: What’s the timeline for 1.5.0?
@Matt_Robinson: I honestly don’t know, we still have a lot of PHP8 work to complete,
@Joy_Reynolds: Is PHP 8 the defining factor of 1.5.0?
@Matt_Robinson: It certainly was the main priority focus as I understand it.
@Joy_Reynolds: So, how best to utilize this time?
@Matt_Robinson: Any PRs in the 1.5.0 milestone, especially anything with a PHP8 label
Gone in terms of PHP security support, but it won’t disappear overnight - on my hosting I can use PHP 5.5 if I want and 8.0 isn’t an option at the moment.
The withdrawal os support does make PHP8 a pressing issue though.
@Joy_Reynolds: Yes, I meant support. And they released a 7.4.33 today…
@Matt_Robinson: PR #1150 looks good to merge to me, updated the $wp_version
string to 4.9.22.
@Simone_Fioravanti - have you had a chance to test #1137?
https://github.com/ClassicPress/ClassicPress/pull/1137
@Simone_Fioravanti: 1137 is already on test on a live site. It’s running for about three weeks without errors.
@Matt_Robinson: Reasonable to merge then and see if that reduced PHP8 test issues?
@Simone_Fioravanti: Yes, agree. And in this way we can test that more in nightly builds.
Do you know why nightly builds are not being updated in 7 days?
@Joy_Reynolds: no changes to build?
@Matt_Robinson: Maybe because the GitHub API was regenerated so we could re-enable the Renovat bot.
There are a lot of Depency updates from the last week when it was re-enabled.:
https://github.com/ClassicPress/ClassicPress/pulls
I’m not even sure where the nightly build are generated from! There was a commenter script that ran on the Renovate tickets that was spamming us so we suspended Renovate. Seems like regenerating the token broke the nightly builds.
@Simone_Fioravanti: Instructions tell to set up the script as a cron, don’t know where it lives.
@Matt_Robinson: My worry is that it is on one of James Nylen’s server, same as the commenter bot and we have been unable to reach him. Maybe we need to set it up again on a server we control.
I can look at the Dependency PRs over the next week if everyone is happy with that. We need to clean up some issues in the automated testing before the end of the year as the Ubuntu 18.04 platform is being ended.
Interesting the PHPUnit tests failed on Sunday due to test_get_gmt_from_date_string_date
failing! Must have been due to DST change.
After merge of #1137 it seems we only have 1 failing unit test in PHP8
https://github.com/ClassicPress/ClassicPress/actions/runs/3387482351/jobs/5628274792
@Simone_Fioravanti: Great… there were many before!
Where can I see the failing test?
@Matt_Robinson: It’s in one of our tests too I think. In the link to the test above, open up the “Run PHPUnit Default” list. You need to be logged in on GitHub to see it.
@Joy_Reynolds: “reset Password”
@Matt_Robinson: Anything else we can accomplish in the last few minutes?
@Joy_Reynolds: I made the change in my theme PR, from esc_attr
to sanitize_key
.
I think perhaps my test cases are not quite comprehensive.
@Matt_Robinson: I’m surprised WP are not doing this given the drive to headless themes and theme.json files. What more needs done in the tests?
@Joy_Reynolds: I didn’t try a hack to see if it was removed. I didn’t put unwanted characters in the attribute name.
@Matt_Robinson: So, maybe try adding tests that should fail you mean?
If you are looking at the tests anyway you might want to swap from assertEquals
to assertSame
.
@Joy_Reynolds: Not failing the test, but testing the code.
@Matt_Robinson: By ‘failing’ I was meaning more like assertNotSame
, so if passing escaped characters you could check that the character is unescaped and also check that the new string doesn’t still contain escaped characters for example.
Okay, my time today is up, until next week.