View in #core on Slack
@Matt_Robinson: It’s time for the weekly PR review meeting. Who online?
I note the entry above about an upstream security fix, I cannot see any evidence of this myself - happy to look if links are provided.
@Joy_Reynolds: Yeah, I didn’t see it either.
@Matt_Robinson: The milestone for 1.5.0 is clear again, we are trying to get a time when I can show the release process to some other community members but so far we have not found a mutually convenient time to suit.
@Joy_Reynolds: If there will be more than one RC, just go ahead with RC1 and get together for RC2.
@Matt_Robinson: I hoping there will only be one RC :rolling_on_the_floor_laughing:
@Joy_Reynolds: Well, it’s sad to delay a RC just for that.
@Matt_Robinson: I am starting to wonder though if we need to just get on with it.
@Joy_Reynolds: We need to get the PHP8 stuff out.
@Matt_Robinson: I have been using the current
develop on my sites - just as well as my provider updated PHP and MySQL - killed the server for 2 days in the process but, you know - progress…
@Joy_Reynolds: Yeah, I moved to Ubuntu 22.04 and PHP8 and now can’t run my older WP or CP local sites.
@benlumia007: i kinda need the PHP 8.0, my framework will be based on 8.0/8.1 and i need to get this out soon
@Matt_Robinson: @Viktor was looking at my RC release draft on the forum, perhaps my time would be better spent today just making the RC release.
@benlumia007: @Joy_Reynolds need to install php 7.4 for older WP/CP installs
@Matt_Robinson: WP backport important security fixes but with PHP 8 now pretty much all older version are non-starters.
@Joy_Reynolds: WP finally released the EOL for 3.7 - 4.0
We could use that same strategy for CP 1.x in future.
@Matt_Robinson: I reported our issue with QUnit tests hanging to GitHub:
@Joy_Reynolds: it says 22nd of December
@Matt_Robinson: I need a proof reader! Corrected now but seems they recognise the issue, others have faced similar issues.
@Joy_Reynolds: So, you will do the RC? What’s left for that?
WP is still making changes for PHP8.
Or did we get all the PHP 8.0 and now have to do PHP 8.1?
@Matt_Robinson: I think WP are more focussed on PHP 8.1 aren’t they?
If there is nothing further today maybe I can look at the RC.
@Joy_Reynolds: Did you get a chance to look at my front end attribute PR?
@Matt_Robinson: No, not yet.
@Joy_Reynolds: I’m just wondering if it makes backports harder, by changing code to use a new function.
And the one function that isn’t following coding standards is a bit tricky. If I expand the arrays over multiple lines to satisfy the standard, then it doesn’t like the indentation, which I didn’t change.
I am tempted to rework the whole function so that the filters are called in proper order.
@Matt_Robinson: Everything we have changed makes backports harder if the same files are affected, but as a community the future vision for ClassicPress needs to be decided.
Are you talking about the
cp_attributes() work? Is that reasonable then to leave in
develop for the RC release?
@Joy_Reynolds: That “work” is in two parts. The first is merged, which is good. The second is not complete and needs the first in place to build upon.
@Matt_Robinson: Ah, I see. The second bit then. Okay, I’m going to look at the RC now then.
RC release zip is here fore downloading and review / testing: