View in #core on Slack
@Matt_Robinson: Weekly PR review time, shall we see if we are ready to finalise PRs for 1.5.1?
@Viktor: Yes please.
@Matt_Robinson: First is this:
Was discussed on forums and seeming fixed. It may be just an understanding issue with the comment posted on the PR, but it has been tested and looks to be a good fix. No update from the OP.
@Viktor: Yes, I tested it and it works. No issues/errors noticed.
@Simone_Fioravanti: Tested and works as intended.
@Matt_Robinson: I’ll set that merging now.
We also have the update to the readme:
I’ve just had a brief skin over the updated file - seems okay - @Viktor - what are the major changes?
@Viktor: primarily updated requirements. and then added some extra funding info.
So do please verify if requirements are correct.
@Matt_Robinson: Looks fine to me on the requirements - seems about right but doesn’t match here:
So do we update the website or the readme?
Specifically in the readme we say recommended for PHP 8, on the website it’s 7.4 / 8.0, 8.1 work ongoing.
My feeling is we should recommend PHP 7.4 or 8.0 in both locations and remove the 8.1 sentence from the website.
@Viktor: I did initially set recommended PHP as 7.4 - 8.0, but that failed a test. So I removed 7.4, test passed.
Failed asserting that an array is not empty.
I think test is checking for a single value.
@Matt_Robinson: I just reached the same conclusion. Given that 7.4 is no longer supported then, lets recommend 8.0?
@benlumia007: i also agree
but since PHP 7.4 is still an active thing, how would a theme with 7.4 work if a user decides to install and activate in the WP repo through the dashboard
i’m just curious
@Matt_Robinson: So, readme is fine as it stands, website needs updated.
@Viktor: We’re discussing recommended version, but minimum requirements for v1.x are still PHP 5.6.
In v1.x, PHP 7.4 will always work. It’s an LTS version. In v2.0, 7.4 should be the minimum.
@Matt_Robinson: Okay, who can update the website - is that you @Viktor ?
I’ll set the readme merging now.
@Viktor: Already updated.
@Matt_Robinson: Great - did that PR close this issue:
Thanks, okay so looks like we might be ready for 1.5.1.
I have an update to the release script as detailed here:
I can’t make a realse right now but probably over the weekend.
Is everyone happy we can make a 1.5.1 bug fix release?
@Viktor: Yes, looks good.
@benlumia007: this is probably out of scope, do we think PHP 8.1 will be included in v1 or v2
@Matt_Robinson: Okay, I’ll plan som time and mage the release and test that update.
Anything else for today?
PHP8.1 will be v2 I suspect.
@Viktor: I think so too. CP 1.5.0 seems to work with 8.1 as reported by others. If anyone reports issues, we can implement fixes in v1.x for 8.1 as needed.
@benlumia007: it’ll probably work without deprecated notice if the Debug is not on
i can test it later, my environment is up to 8.2
i only have PHP 7.4 because of WP is too slow to adopt 8.0 since WP core is at 7.4 still sigh
@Matt_Robinson: The bigger problem is failing unit tests with the current v1 code in PHP 8.1, that’s a lot of work to fix when we should probably just work on v2.
@benlumia007: v2 should be okay
my biggest issue is PHP 8.0 since my entire framework is based on 8.0, i did a small change so it works on 7.4
dumb WP lol
@Matt_Robinson: Thanks to everyone for your help today. I’ll aim for 1.5.1 over the weekend and will make a post here on core when I get time in case anyone is available to help out.