View in #core on Slack
@Matt_Robinson: Hello! Who is online to discuss core development?
Simone has messaged me and can’t attend this week.
I think the main topic for today’s meeting would be an update on your progress?
A separate question, should we create a new repo for the new version of v2?
@Matt_Robinson: I have been manually
diffing the current CP code base against WordPress 6.1.1. I’ve progress a bit past that to WordPress
trunk now. Locally at a brief glance the site is working and QUnit tests are updated and passing. PHPUnit needs a lot of work though - currently a lot of failures (around 200) and a huge number of errors (over 1000). These are highlighting some issue in the code that may break working sites so more to do.
As I’m updating from the current code base I can just create a branch in the usual ClassicPress repository.
@Viktor: If the code is up in the repo, I can go through and see what I can find that I can help with.
moment - these could be develop dependencies and I can have aGrunt task drop them in place.
The challenge is going to be the
@wordpress packages from Gutenberg used in the Site Health page and the Quick Edit modals.
We may need to condsider if and how we build those into core - at the moment I’ve just dropped the files in the necessary location.
If you are happy to look through and test I’ll push some code when I have PHPUnit testing behaving a bit better - I’m part way through a task that I’d want to finish up first.
We touched last week on using
gettext filters to amend the links to the forums on-the-fly and the more time I spend buried in the code the more I feel that is a great solution so I’m updating the links now.
We will need to replace:
<a href="<https://wordpress.org/support/forums/>">Support forums</a>
<a href="<https://forums.classicpress.net/c/support>">Support Forums</a>
@Viktor: If there is an example implementation, I’m sure it’s something I can help with. I’ve used gettext before, just not in the core.
@Matt_Robinson: The challenge with the
@wordpress packages is re-creating the build steps for our own purposes. The code is written in JSNext and needs to be compiled before it can be used by browsers. That’s why WordPress has a build step before you can spin up a localhost.
@Viktor: Can that build step be in Actions?
@Matt_Robinson: I think Simone was practically there with the
gettext filter as he did some testing last week.
We tend to use Actions more for testing, Grunt would be used for the build process.
@Viktor: You’ve asked about Security page before. I think that needs to be removed. That was the intent before v2. Hide it in one version, and then remove it in the future. So in v2, we should remove it.
@Matt_Robinson: Ah, thanks for that reminder. I will pull those files out then - simple job while I’m in this process.
I can’t think of anything else we need to cover at the moment…
@Viktor: I think that covers it for now. Once you push the code to repo, let us know so we can take a look at it and see what we can help with.
@Matt_Robinson: I’ll aim to get something in the next week then even if I an still not at fully passing PHPUnit tests.
@Viktor: Sounds good.