View in #core on Slack
@Matt_Robinson: Weekly meeting time! Anyone online?
So, update on my V2 work, thanks to @Simone_Fioravanti for submitting a PR to re-introduce the plugin upload menu, that is merged.
I’ve got to a stage where the @wordpress packages are building and minimising with a new task registered in the Gruntfile.js process and those files are also skipped for js-validation as they break.
I’ve managed to make significant progress on PHPUnit testing and as far as I can tell locally not many tests are failing now and there are no errors.
I have 2 tests failing locally related to i18n.
All of this has been pushed to my fork earlier today.
@Viktor: That’s great progress, good job!
@Simone_Fioravanti: You have done a great job!
I’ve tested the branch. Confirm 2 tests failing.
I’ve something I can’t fix…
@Matt_Robinson: Are you able to run image tests locally - GD or Imagick? I don’t have things configure right at the moment, maybe one day I’ll figure it out!
@Simone_Fioravanti: Give me some hints to check please…
@Viktor: I’m using Docker to run local instance of CP. Both are active.
@Matt_Robinson: composer run phpunit -- --group=image
Should run 222 tests, currently I have 33 skipped with:
The image editor engine WP_Image_Editor_Imagick is not supported on this system.
@Simone_Fioravanti: Re-running tests after enabling Imagick…
@Matt_Robinson: Adding a -v to that command should give more output too if needed.
@Viktor: From user testing, I have not seen issues uploading images yet.
@Matt_Robinson: I’m not sure you’d see errors as the code will not process the image without the library being available - so elegant and silent failure.
@Simone_Fioravanti: Same 33 tests skipped. The image editor engine WP_Image_Editor_Imagick is not supported on this system.
@Matt_Robinson: Viktor, are you seeing more in your Docker environment?
@Viktor: I haven’t run any tests. I would need to set it up.
Last time I tried directly on Windows, it was having errors. But I haven’t tried on Docker.
@Matt_Robinson: Or we can just run them up on GitHub now.
That may need a little editing of the WorkFlow files first.
In terms of moving to V2, we are going to need to branch the existing code - is the idea that we maintain support and backport security fixes? When would we stop doing that?
@Simone_Fioravanti: Don’t know if it’s better to have a new repo for V2… so keeping up with V1 is easier (maybe?)
@Matt_Robinson: That might work too, releases would still be pushed to ClassicPress_release - we do need to figure out a way to fully test the core update code in V2, we really don’t want circular or failing updates.
@Simone_Fioravanti: Think it depends on how we deal with it on our API
@Matt_Robinson: In terms of support for V1, it officially support PHP8.0 which is no longer actively supported and only gets security support until November. So, on that basis support until November with notification to users that we will stop support when PHP8.0 support stops may be reasonable.
@Viktor: OK, I agree. That sounds reasonable. If WordPress releases a security patch to 4.9.x branch in the future, can we still backport it and release it to 1.x? Just curious.
@Matt_Robinson: As things currently stand, yes. If we over-write the develop branch with V2, maybe no, certainly no easily. Perhaps a new repository is a better solution. But tha may make creaing a PR a challenge as my current fork is set to upstream to V1.
@Simone_Fioravanti: But we can clone ClassicPress repo to ClassicPress2 repo and then you can open a PR to the last one.
Do you tried to switch between develop and v2-cp? It works nice. I’ve just had an SSL issue solved my deactivating and reactivating SSL in MAMP, but maybe it’s MAMP-related.
@Matt_Robinson: I’m sure I can jus change he upstream if we create a new repository from he current ClassicPress one.
@Simone_Fioravanti: Having two repo can also help with issues. Now I can do a PR but not open issues about v2.
@Viktor: A clean repo for v2 can be good, so the issues/PRs for v1 can be eventually archived. And v2 receive new stuff.
I would make v2 repo the new /classicpress/classicpress repo while the old one would become /classicpress/classicpress-v1 repo.
@Matt_Robinson: Having 2 repositories may make things easier and we can archive V1 when we stop supporting it. I jus don’t like how that will lave a ‘2’ in he only available version!
Viktor’s idea of renaming curren to -v1 is neat though.
@Simone_Fioravanti: Agree!
Before that, where can I open issues? Here?
@Matt_Robinson: What kind of issues?
@Simone_Fioravanti: One as example: Custom login images is missing some part of the original PR, unit tests and a fix done by James.
Can’t get a PR for that.
@Matt_Robinson: Double check my latest code, I may have fixed some of that in the last week. If not a PR over to my respiratory before we PR it to the main repository might be best.
@Viktor: Should I create new repo now?
@Matt_Robinson: Can you duplicate the current ClassicPress then rename the old one?
Or it it worth waiting for a bit more esing and hopefully fixing those last 2 errors?
@Viktor: I don’t think I can duplicate a repo, but I can import an existing repo into new repo. It’s up to you how you want me to proceed. What do you think?
@Simone_Fioravanti: It’s almost the same, when you create a new repo you have this:
@Viktor: Right.
@Matt_Robinson: If it is relatively easy to rename them, shall we create a V2, update to that with the code change and tidy the things I’ve messed up and missed so far, and then rename current to V1 and V2 to ClassicPress
@Viktor: Yes, renaming is easy and I think that’s a good way to proceed without touching current v1 repo.
New repo will be classicpress-v2, and then when we’re ready to switch, old repo will become -v1 and the new repo will become classicpress.
@Matt_Robinson: Oh, that looks very straightforward! That seems like a good way then, new v2, import, get it all readythen rename current tov1and thenv2` to current.
@Viktor: Do you want me to import current v1 repo into v2 repo, or import your forked repo?
@Matt_Robinson: Can you import from the specific branch on my repository? If so, hen you might as well do that.
@Viktor: let me check
@Matt_Robinson: That will also make it easer for future Issues and PRs.
@Viktor: It doesn’t give me an option to import a specific branch. However, if I create a clean repo without import, you can import your branch to new upstream, right?
@Simone_Fioravanti: Seems that is not possible, but import v1 into v2 and then PR your branch on v2, so you can also rebase your commits if you need.
@Matt_Robinson: 
This is the way.
@Viktor: This is what StackOverflow says:
@Matt_Robinson: So I should be able to clone the new repository and push all my branch code to it then. I can certainly have a try.
@Viktor: That’s what I did with WordPress Importer plugin repo.
If I could do it, anyone can do it 
You both have been added to: https://github.com/ClassicPress/ClassicPress-v2/
@Simone_Fioravanti: I see it’s empty. Ok… I’ve missed a point!
@Matt_Robinson: I’ve cloned he new location and am pulling in my branch now (I hope) but it’s quite large. Leave it with me and I’ll see what I can do. I need to move on to other things now - thanks as always.
@Simone_Fioravanti: Thank you 
@Viktor: Thanks!