View in #core on Slack
@Matt_Robinson: Weekly Core review time, who is online?
Update from the last week, we now have the nightly build process working for v2
. I think that the API for update json files is created from the release repositories so I’ve added the v2
nightly to that process, but I have also found (I think) that the file generation relies on semver version numbers. We had v2
at 2.0, so I’ve updated to 2.0.0 and hopefully the API can then start updating correctly.
We have released 1.5.3 with backported security fixes, the API now allow migration from WordPress 6.2.1 and directly to ClassicPress 1.5.3 in the migration plugin.
I have also updated the v2
source with the 3 changes (one additional changeset was needed) from WordPress 6.2.1.
@Viktor: Great job. I will begin testing nightly. I have a blog I built using WP because I needed a specific plugin. So I will test v2.0 to replace/migrate from WP 6.2.
@Matt_Robinson: I’ve been building v2 and using on my own sites, if you are going to use the nightly, I’d suggest wait for the one that build overnight and grab it tomorrow, rather than the only one showing at the moment - it will then containn the security fixes.
@ElisabettaC77: How do I test the nightly? Is it the same as with rc that have a url to paste in migration plugin?
@Matt_Robinson: @ElisabettaC77 - I don’t think that will work, let me just check.
So, I don’t think automatic migrations will work yet as the directory structure isn’t correct. You can download nightlies from here and FTP the files, or we can re-instate the migration build process - I stopped that as I thought it might be a bit premature to create migration builds just yet.
@Viktor: You should be able to use WP-CLI to force install/upgrade a new version:
wp core update <https://nightly.zip> --force --allow-root
@ElisabettaC77: Where is “here”? The repo of the V2? It would work like manual install then. Ok. Perfect
@Viktor: No, you need nightly repo:
https://github.com/ClassyBot/ClassicPress-v2-nightly
See “Releases” to get zip file.
@ElisabettaC77: Ok for the repo, the WP-cli is a good option but I still need to learn it. And testing every step (even installation) can help spot issues if any.
@EliteStarServices: I assume you can also copy those files over an existing installation?
I do not use WP-CLI
@Viktor: Yes. That should work too. It should trigger database migration too.
@ElisabettaC77: Probably. But as far as I understand better not?
I will try both ways. The more tests the better and I have the weekend to play with it
@Matt_Robinson: Copying the files over is fine - just make sure you leave wp-config.php
and the wp-content
folder alone.
@EliteStarServices: I would backup first anyway in case it craps out.
@Viktor: Please don’t test in production yet
Unless you want extra work.
@EliteStarServices: LOL
@ElisabettaC77: I am not testing on production. I will just test V2 like it’s a new shiny toy to destroy.
@EliteStarServices: I have an assortment of test sites I would crash first.
@Matt_Robinson: In fact to make sure there are no unnecessary files left over I tend to copy wp-admin
and wp-includes
over with a character appended, then rename the original folders on the server and then remove the appended character. Tends to upload faster too so less down time on live sites.
And of course, backup massively before you start the process.
@ElisabettaC77: However in case I break the toy (considering I am a pro it can happen) where has that to be reported? Same repo where it came from or here?
@Matt_Robinson: Report any issues here please:
https://github.com/ClassicPress/ClassicPress-v2/issues
@ElisabettaC77: Perfect.
@Viktor: One thing to note, at this time, all links in admin will still link to WP pages. That will change soon. So no need to report links.
@Matt_Robinson: What we also need to be looking out for are mentions of the Block Editor. I have found some examples in the Site Health pages, there is a test of the REST-API and the text says it is used by the Block Editor. I think anything like that we should probably strip out.
@ElisabettaC77: That I was aware (there was that change planned with get_text() if I recall correctly?)
@Matt_Robinson: The links to Support should come back to the CP forum, but there will be a lot of contextual help that links back to WordPress. It does avoid u having to write (copy) a ton of documentation.
@ElisabettaC77: Yes that is clear.
@Viktor: Hopefully, we’ll get more documentation pages in CP docs.
@Matt_Robinson: One we have the documentation pages we can add to the translation hack we created, it’d be nice to have the same URL structure so we can just str_replace
the first part of the URL. But that may be a big ask on the documentation front.
@Viktor: There are several different variations of sub-domains WP uses. So it’s not as uniform as one would hope.
@Matt_Robinson: It seems there is work going on centralising that as I’ve have noted some of those being updated during the creation of v2
.
@Viktor: They are separating user and developer docs.
I thought about this too, for CP docs. But using single CP with custom post types instead of multiple sub-domains.
@ElisabettaC77: As concerns sub domains I agree. As concerns docs, there is something nagging in the back of my head. Once upon a time James said he forked all the codex and stuff (it was late 2018/early 2019 or so) but that these needed to be cleaned and the like. That was never done I think, but this codex fork should be somewhere just waiting to be used? At least it is something. Then we can build a “user facing documentation” on the example of the user facing docs that WP has (I worked on that and I remember how it was organized, even if we do not have the fork of the old thing it’s pretty easy to put up a knowledge base kind of thing).
I mean, we can build a clean user facing manual that is very organized and make it so that is in a centralized place (a site where they click developer button and reach codex and user and they get to the manual)
@Matt_Robinson: There are some docs repos under the ClassicPress github user.
@Viktor: yes, that’s the tracker: https://github.com/ClassicPress/Documentation-Issue-Tracker
ClassicPress/Documentation-Issue-Tracker
@ElisabettaC77: And the codex is from the WP 4.9 times, so we just need to strip it of all the references to WP and read it carefully to check if we can reword it a little to suit CP in full (and avoid a possible risk of WP having a reason to be angry at us for copying the codex)
@Viktor: Code reference needs to be generated for each version of CP. Last time I checked, the script was broken. We’ll need to revisit it for v2.0
@Matt_Robinson: I’ve been looking at some of the Renovate PRs and merging those while we’ve been discussing. Anyone have anything else to raise today?
@Viktor: Nothing from me.
@ElisabettaC77: it’s all ok for me too.
Thanks for the fast release following the reports of issues yesterday it’s all that really has to be said. And thanks for working on v2
@Matt_Robinson: Thanks everyone. Lets see where testing gets us and what drops out when we shake the v2
tree! I’m hoping nothing major!