Remove side-effects

discobot · December 30, 2020, 8:24pm

PSR-1 says

A file SHOULD declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it SHOULD execute logic with side effects, but SHOULD NOT do both.

github.com

php-fig/fig-standards/blob/master/accepted/PSR-1-basic-coding-standard.md#23-side-effects

# Basic Coding Standard

This section of the standard comprises what should be considered the standard
coding elements that are required to ensure a high level of technical
interoperability between shared PHP code.

The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD",
"SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be
interpreted as described in [RFC 2119].

[RFC 2119]: http://www.ietf.org/rfc/rfc2119.txt
[PSR-0]: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-0.md
[PSR-4]: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-4-autoloader.md

## 1. Overview

- Files MUST use only `<?php` and `<?=` tags.

- Files MUST use only UTF-8 without BOM for PHP code.

This file has been truncated. show original

We have class files and files full of functions with side-effects It would be the first step towards class autoloading.

Read-only archive: Issues · ClassicPress/ClassicPress · GitHub

Author: Viktor Szépe

Vote count: 5

Status: open

Comments

system · December 20, 2021, 5:10am

viktor · June 23, 2022, 9:41pm

Since this is part of coding standards, we have another completed petition specifically for coding standards. This petition seems to be a duplicate as it only focuses on one specific part of PSR-1. Unless there are objections, this duplicate petition will be closed.

viktor · June 26, 2022, 9:41pm

This topic was automatically closed after 3 days. New replies are no longer allowed.